Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.16](backport #42079) [filebeat][netflow]: fix template sharing #42137

Merged
merged 2 commits into from
Dec 27, 2024
Merged

[8.16](backport #42079) [filebeat][netflow]: fix template sharing #42137

merged 2 commits into from
Dec 27, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 20, 2024

Proposed commit message

Pass the share_templates configuration option into the NetflowV9Protocol
struct. The parameter was not being set, and therefore was always false so
it was not possible to use this option.

Added a test case to prevent future regressions.

Closes #42080

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

This is an automatic backport of pull request #42079 done by [Mergify](https://mergify.com).

@simioa @mergify
[filebeat][netflow]: fix template sharing (#42079)
c6771d6 
Pass the share_templates configuration option into the NetflowV9Protocol
struct. The parameter was not being set, and therefore was always false so
it was not possible to use this option.

Added a test case to prevent future regressions.

Closes #42080

(cherry picked from commit 323c69e)
@mergify mergify bot added the backport label Dec 20, 2024
@mergify mergify bot requested a review from a team as a code owner December 20, 2024 14:10
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 20, 2024
@botelastic
Copy link

botelastic bot commented Dec 20, 2024

This pull request doesn't have a Team:<team> label.

@mjwolf mjwolf enabled auto-merge (squash) December 27, 2024 02:08
@mjwolf mjwolf merged commit 3c9253f into 8.16 Dec 27, 2024
22 checks passed
@mjwolf mjwolf deleted the mergify/bp/8.16/pr-42079 branch December 27, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjwolf mjwolf mjwolf approved these changes

Assignees
No one assigned
Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjwolf @simioa